Skip to content

Commit

Permalink
Merge pull request #365 from oscar-system/array_string_type
Browse files Browse the repository at this point in the history
Fix typemapping for `Array{String}`
  • Loading branch information
benlorenz authored Oct 8, 2021
2 parents 15d2cd3 + 4fec87b commit c704427
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions test/perlobj.jl
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,10 @@
@test Polymake.get_attachment(Polymake.PropertyValue,test_polytope,"ATT") isa Polymake.PropertyValue
@test Polymake.remove_attachment(test_polytope,"ATT") === nothing
@test Polymake.get_attachment(test_polytope,"ATT") === nothing

stra = Polymake.Array{String}(["hello", "world"])
@test Polymake.attach(test_polytope, "STRA", stra) === nothing
# @test Polymake.get_attachment(test_polytope) .== ["hello", "world"]
end

@testset "tab-completion" begin
Expand Down

2 comments on commit c704427

@benlorenz
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/46343

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.6.0 -m "<description of version>" c704427d977328bd50bfd7ba24a9b3df9d8069ec
git push origin v0.6.0

Please sign in to comment.