Merge pull request #399 from oscar-system/bl/safercast

oscar-system · May 31, 2022 · 0a3773f · 0a3773f · benlorenz · Jun 3, 2022
2 parents 9242f08 + f1de4ba
commit 0a3773f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "Polymake"
 uuid = "d720cf60-89b5-51f5-aff5-213f193123e7"
 repo = "https://github.com/oscar-system/Polymake.jl.git"
-version = "0.7.2"
+version = "0.8.0"
 
 [deps]
 BinaryWrappers = "f01c122e-0ea1-4f85-ad8f-907073ad7a9f"

diff --git a/src/perlobj.jl b/src/perlobj.jl
@@ -5,8 +5,12 @@ function bigobject(fname::String; kwargsdata...)
 end
 
 function bigobject(fname::String, other::BigObject; kwargsdata...)
-    obj = BigObject(BigObjectType(fname), other; kwargsdata...)
-    return obj
+    type = BigObjectType(fname)
+    # use converting copy but make sure types are related
+    if _isa(other, type) || _isa(BigObject(type), bigobject_type(other))
+        return BigObject(type, other; kwargsdata...)
+    end
+    throw(ArgumentError("cannot copy-convert unrelated types: $(Polymake.type_name(other)) to $(Polymake.type_name(type))"))
 end
 
 function bigobject(fname::String, name::String; kwargsdata...)

diff --git a/test/perlobj.jl b/test/perlobj.jl
@@ -81,6 +81,7 @@
             @test polytope.Polytope(c) isa Polymake.BigObject
 
             @test_throws ErrorException Polymake.cast!(c,Polymake.BigObjectType("fan::PolyhedralFan"))
+            @test_throws ArgumentError fan.PolyhedralFan(c)
         end
     end