Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit Any for all @attr functionexpr cases #4070

Merged
merged 1 commit into from
Sep 5, 2024

Add explicit `Any` for all `@attr functionexpr` cases

6490ff7
Select commit
Loading
Failed to load commit list.
Merged

Add explicit Any for all @attr functionexpr cases #4070

Add explicit `Any` for all `@attr functionexpr` cases
6490ff7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 4, 2024 in 0s

84.66% (+0.48%) compared to 629c37e

View this Pull Request on Codecov

84.66% (+0.48%) compared to 629c37e

Details

Codecov Report

Attention: Patch coverage is 86.36364% with 12 lines in your changes missing coverage. Please review.

Project coverage is 84.66%. Comparing base (629c37e) to head (6490ff7).

Files with missing lines Patch % Lines
src/Modules/mpolyquo.jl 72.72% 3 Missing ⚠️
...ometry/Schemes/AffineSchemes/Objects/Attributes.jl 88.23% 2 Missing ⚠️
experimental/Schemes/src/AlgebraicCycles.jl 0.00% 1 Missing ⚠️
...ental/Schemes/src/MorphismFromRationalFunctions.jl 50.00% 1 Missing ⚠️
experimental/Schemes/src/WeilDivisor.jl 75.00% 1 Missing ⚠️
...try/Schemes/ProjectiveSchemes/Morphisms/Methods.jl 50.00% 1 Missing ⚠️
...ry/Schemes/ProjectiveSchemes/Objects/Attributes.jl 85.71% 1 Missing ⚠️
src/Modules/mpoly-localizations.jl 75.00% 1 Missing ⚠️
src/Rings/primary_decomposition_helpers.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4070      +/-   ##
==========================================
+ Coverage   84.17%   84.66%   +0.48%     
==========================================
  Files         600      600              
  Lines       82568    82627      +59     
==========================================
+ Hits        69503    69956     +453     
+ Misses      13065    12671     -394     
Files with missing lines Coverage Δ
experimental/GModule/src/GModule.jl 63.02% <100.00%> (+2.43%) ⬆️
experimental/Schemes/src/CoherentSheaves.jl 77.81% <100.00%> (ø)
...perimental/Schemes/src/CoveredProjectiveSchemes.jl 88.30% <100.00%> (ø)
experimental/Schemes/src/CoveredScheme.jl 94.50% <100.00%> (ø)
experimental/Schemes/src/IdealSheaves.jl 79.93% <100.00%> (+1.21%) ⬆️
experimental/Schemes/src/elliptic_surface.jl 91.23% <100.00%> (+3.96%) ⬆️
...y/Schemes/AffineAlgebraicSet/Objects/Properties.jl 100.00% <100.00%> (ø)
...metry/Schemes/CoveredSchemes/Objects/Attributes.jl 86.15% <100.00%> (ø)
src/AlgebraicGeometry/Schemes/Gluing/Attributes.jl 92.59% <100.00%> (ø)
.../Schemes/PrincipalOpenSubset/Objects/Properties.jl 100.00% <100.00%> (ø)
... and 17 more

... and 31 files with indirect coverage changes