Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pretending OscarInterface has a manual #3968

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Jul 24, 2024

We might add one in the future, but for now there is none.

This may resolve (edit: it does not) #3967 but I am not sure as I don't fully understand what causes that one.

We might add one in the future, but for now there is none.
@lgoettgens
Copy link
Member

The message still occurs in https://github.com/oscar-system/Oscar.jl/actions/runs/10074052750/job/27849342956?pr=3968#step:9:235, so #3967 doesn't get resolved

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.09%. Comparing base (6724004) to head (41dba31).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3968   +/-   ##
=======================================
  Coverage   84.09%   84.09%           
=======================================
  Files         593      593           
  Lines       81744    81757   +13     
=======================================
+ Hits        68745    68757   +12     
- Misses      12999    13000    +1     

see 1 file with indirect coverage changes

Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes are a correction, the files claimed in the old version do not exist, and an empty list as PackageDoc value is allowed.

@ThomasBreuer ThomasBreuer merged commit 77a500e into oscar-system:master Jul 24, 2024
29 checks passed
@fingolfin fingolfin deleted the mh/OscarInterface-doc branch July 24, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants