Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ergonomics of v3 writer + add compression options #23

Merged
merged 6 commits into from
Aug 8, 2023

Conversation

Uinelj
Copy link
Member

@Uinelj Uinelj commented Aug 8, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #23 (461056c) into dev (c133f21) will increase coverage by 4.30%.
Report is 15 commits behind head on dev.
The diff coverage is 84.04%.

@@            Coverage Diff             @@
##              dev      #23      +/-   ##
==========================================
+ Coverage   32.34%   36.64%   +4.30%     
==========================================
  Files           9       11       +2     
  Lines         640      704      +64     
==========================================
+ Hits          207      258      +51     
- Misses        433      446      +13     
Files Changed Coverage Δ
src/oscar_doc/reader.rs 79.20% <ø> (ø)
src/oscar_doc/types/document.rs 0.00% <0.00%> (ø)
src/oscar_doc/types/metadata.rs 0.00% <0.00%> (ø)
src/oscar_doc/writer.rs 100.00% <ø> (ø)
src/v3/types/document.rs 52.23% <0.00%> (-3.15%) ⬇️
src/v3/writer/docwriter.rs 87.50% <87.50%> (ø)
src/v3/writer/writer.rs 94.36% <94.20%> (+22.93%) ⬆️

... and 1 file with indirect coverage changes

@Uinelj Uinelj merged commit 2635e64 into dev Aug 8, 2023
3 checks passed
@Uinelj Uinelj deleted the uj/osc-75-group-split-and-compress-steps branch August 8, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant