-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add html validation to build process #1659
Conversation
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
…g it Signed-off-by: Chris Butler <[email protected]>
…g it Signed-off-by: Chris Butler <[email protected]>
…g it Signed-off-by: Chris Butler <[email protected]>
Okay this is good to go. All dead links are stripped @jpower432 |
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One suggestion on a link change.
docs/tutorials/ssp_profile_catalog_authoring/ssp_profile_catalog_authoring.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Chris Butler <[email protected]>
docs/tutorials/ssp_profile_catalog_authoring/ssp_profile_catalog_authoring.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks like you uncovered some broken links. I'm flagging as request changes for now, modulo a final decision on the IBM ssp-demo link.
In #1688 I note that I asked JJ to move the repo. I think it will happen pretty quickly. I suggest updating the link in this PR. |
Signed-off-by: Chris Butler <[email protected]>
Good to go now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Chris Butler [email protected]
Types of changes
develop
->main
)Quality assurance (all should be covered).
Summary
Adds validation fo HTML to ensure no dead links exist in the docs site.
Key links:
Before you merge