many: test for exclude when comparing images/otk manifests
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit regenerates the reference images with the new `exclude:` prefix as outlined in osbuild/images#938
mvo5
force-pushed
the
test-for-excludes-too
branch
from
6331129
to
f5b1396
Compare
This commit follows osbuild/images#938 and adjust the way excludes are represented.
This commit adds a missing exclude that the new test uncovered.
This commit fixes the grub2 fragments that require changing after: osbuild/images#943 osbuild/images#937 We now create predictable versions/release for fake kernels and also include the architecture.
mvo5
force-pushed
the
test-for-excludes-too
branch
from
f5b1396
to
101b24e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses osbuild/images#938 so compare that the dnfjson excludes are also identical between the osbuild manifests that are generated by images and by otk.
It also contain a fix/update for the images pr#943, pr#937