Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pre commit #134

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

schuellerf
Copy link
Contributor

Trigger was #133 where Schutzfile had a typo and it took a while to find it

@schuellerf
Copy link
Contributor Author

schuellerf commented Jul 19, 2024

To test, this should be sufficient:

pip install pre-commit
pre-commit install  # this is global

then mess with Schutzfile and try to commit locally

@schuellerf
Copy link
Contributor Author

btw. we can also integrate this check in github like so:
https://github.com/osbuild/.github/blob/main/.github/workflows/pre-commit.yml#L20
(preferably with an up to date version :-D )

Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks OK. I'm wondering if it would make sense to run tests, which are performed by the pre-commit config but missing in GH actions, as part of PRs?

Mostly to prevent introducing new issues and makinbg life of anyone using the pre-commit hooks harder.

@schuellerf schuellerf merged commit 17373e3 into osbuild:main Aug 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants