cmd/otk-gen-partition-table: implement bootable flag for any partition #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on centos9 for s390x with qcow2 it seems that the root partition shall be bootable. With this fix, this can be defined.
mvo5
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Isn't this duplicating what https://github.com/osbuild/images/pull/963/files#diff-18ee7ce81f59e07d736fd0f3454f0983633e53c0bd833df71b114e8528683280R54 already does? Or am I missing something ?
(ie. 60e7e0d)
|
@mvo5 yes, sorry. I was just splitting up the version I have working locally and didn't double check with the existing PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on centos9 for s390x with qcow2 it seems that the root partition shall be bootable. With this fix, this can be defined.