osbuild: use New{Group,Users}StageOptions() in Gen{Group,Users}Stage() #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently duplicate the code that generates the stage options
for users and groups. AFAICT there is no need for this so this
commit just call the existing functions instead of duplicating them.
If we want to remove New{Group,Users}StageOptions() later (which
a previous commit message indicates) we can still do this by just
unexporting or moving the helper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently duplicate the code that generates the stage options
for users and groups. AFAICT there is no need for this so this
commit just call the existing functions instead of duplicating them.
If we want to remove New{Group,Users}StageOptions() later (which
a previous commit message indicates) we can still do this by just
unexporting or moving the helper.