CI: test integration to osbuild-composer as part of PRs #419
Conversation
thozza
force-pushed
the
run-composer-tests
branch
4 times, most recently
from
b218955
to
c73a2ee
Compare
It would be useful to explicitly test if the code change proposed in the PR integrates cleanly to osbuild-composer or if it will require additional work there. The cheapest way to test it is to try to replace the osbuild/images ref in the osbuild-composer@main and run Golang lint and unit tests. These test cases should not be blocking. The intention is to provide feedback in the PR, that the author (or someone else) should also work on integrating the images change to osbuild-composer, since it won't be "for free". Signed-off-by: Tomáš Hozza <[email protected]>
thozza
force-pushed
the
run-composer-tests
branch
from
c73a2ee
to
a8d5899
Compare
thozza
changed the title
|
Example of a simulated issue is in https://github.com/osbuild/images/actions/runs/7744410267/job/21118086564?pr=419 |
I think that the most reasonable way would be to use a bot account, which could create such PR in composer if asked for it. I'll think about it, since we sometimes want to hold-off merging things in Anyway, my intention with this PR was not to block any new code from landing in |
|
This is great. Thank you!! |
It would be useful to explicitly test if the code change proposed in the PR integrates cleanly to osbuild-composer or if it will require additional work there. The cheapest way to test it is to try to replace the
osbuild/imagesref in theosbuild-composer@mainand run Golang lint and unit tests.These test cases should not be blocking. The intention is to provide feedback in the PR, that the author (or someone else) should also work on integrating the images change to osbuild-composer, since it won't be "for free".