Ensure FIPS files are added to the build #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
requested changes
Feb 6, 2024
There was a problem hiding this comment.
We should test for this. The manifest in the issue should never have been possible to generate. It wasn't a build failure, it was an invalid manifest because it contained a reference to a file that didn't exist in the sources.
We should add at least one test that enables the options so the manifest gets built when it changes.
Make sure the FIPS files are always added to the build when needed. Fixes: osbuild#407 Signed-off-by: Miguel Martín <[email protected]>
|
Clicked rebase because of a test cache change that landed in main: #432 |
achilleas-k
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the FIPS files are always added to the build
when needed.
Fixes: #407
Signed-off-by: Miguel Martín [email protected]