Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many: use bootupd for image.BootcDiskImage #381

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Jan 17, 2024

This commit enables bootupd for the image.BootcDiskImage image type.

@cgwalters
Copy link
Contributor

Note that I still want to do osbuild/bootc-image-builder#18 where bootc owns running bootupd.

@ondrejbudai
Copy link
Member

Don't worry, that's still on our plan, this is just an intermediate step: We want to start firstly using the container itself as a buildroot, and then switch fully to bootc.

@achilleas-k
Copy link
Member

This commit enables bootupd for the iamge.BootcDiskImage image type.

Typo in the commit message :)

@achilleas-k achilleas-k self-requested a review January 17, 2024 15:28
@achilleas-k
Copy link
Member

Would you mind breaking this up into multiple commits? Preferably 3 where:

  1. Changes in pkg/osbuild/
  2. Changes in pkg/manifest/
  3. Changes in pkg/image/

There will of course be some changes that need to happen in image when things change in manifest, but that general separation will help with reading the PR (and the history in the future).

@mvo5 mvo5 marked this pull request as ready for review January 18, 2024 11:49
This commit enables bootupd for the `image.BootcDiskImage` image
type.
@achilleas-k achilleas-k added this pull request to the merge queue Jan 18, 2024
Merged via the queue into osbuild:main with commit a12752b Jan 18, 2024
10 checks passed
@mvo5 mvo5 deleted the image/bootc-use-bootupd branch January 18, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants