-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifest,images: add new manifest.NewBuildFromContainerSpec and use in new BootcDiskImage
(HMS-3318)
#354
Conversation
BootcDiskImage
BootcDiskImage
(HMS-3318)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we discussed this elsewhere but I would prefer if instead we created a Build
pipeline interface with two implementations: an RPM-based one, which is the current Build
pipeline, and a new container-based one.
This commit allows to create a new build root from a container spec. To support build roots based on container inputs we need a way to specify those with images. This commit provides a way to do this.
Add a new `BootcDiskImage` type that is more opinionated then OSTreeDiskImage as the two are more and more diverging. This will be used in `bootc-image-builder`.
3fc09d7
to
c9ffd08
Compare
Thank you! I forgot, fixed this now. Please let me know if that matches what you had in mind :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like this :)
Any reason it's still draft? Should we add an image build of some sort for testing?
Mostly draft as I was not 100% certain if I got the idea right :) Un-drafted now. I am happy to add more testing, I will look into how to do this best, it's slightly incomplete still (but should be enough to build raw images already with |
Let's merge it then and see what happens :D |
This branch prepares for allowing to have build roots from container sources. This is a bit of a shortcut PR that is mainly tailored to
bootc-image-builder
.Alternatively we could change
InstantiateManifest()
to not takerepos []rpmmd.RepoConfig
but instead something like:of course with a more sensible name. Happy to do this if that is the preferred way. I will move this out of draft (or close it) once I get feedback on this (or maybe there is a third option).
Once this is available, bib will use:
Note that this is not sufficient for a full container based buildroot, the following is missing: