Skip to content

Commit

Permalink
distro: explain why we ignore ntp customization
Browse files Browse the repository at this point in the history
When setting the customizations for the kickstart file, we ignore the
ntp server part of the timezone settings.  While kickstart does support
setting these, our kickstart stage does not.  Add a comment for future
reference.
  • Loading branch information
achilleas-k committed Feb 15, 2024
1 parent 59a170d commit 479e652
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/distro/fedora/images.go
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,8 @@ func iotInstallerImage(workload workload.Workload,
img.Groups = users.GroupsFromBP(customizations.GetGroups())

img.Language, img.Keyboard = customizations.GetPrimaryLocale()
// ignore ntp servers - we don't currently support setting these in the
// kickstart though kickstart does support setting them
img.Timezone, _ = customizations.GetTimezoneSettings()

img.AdditionalAnacondaModules = []string{
Expand Down
2 changes: 2 additions & 0 deletions pkg/distro/rhel8/images.go
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,8 @@ func edgeInstallerImage(workload workload.Workload,
img.Groups = users.GroupsFromBP(customizations.GetGroups())

img.Language, img.Keyboard = customizations.GetPrimaryLocale()
// ignore ntp servers - we don't currently support setting these in the
// kickstart though kickstart does support setting them
img.Timezone, _ = customizations.GetTimezoneSettings()

if instCust := customizations.GetInstaller(); instCust != nil {
Expand Down
2 changes: 2 additions & 0 deletions pkg/distro/rhel9/images.go
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,8 @@ func edgeInstallerImage(workload workload.Workload,
img.Groups = users.GroupsFromBP(customizations.GetGroups())

img.Language, img.Keyboard = customizations.GetPrimaryLocale()
// ignore ntp servers - we don't currently support setting these in the
// kickstart though kickstart does support setting them
img.Timezone, _ = customizations.GetTimezoneSettings()

if instCust := customizations.GetInstaller(); instCust != nil {
Expand Down

0 comments on commit 479e652

Please sign in to comment.