Wizard: Add beforeNext conditions to Details step footer

[regexowl]

This adds beforeNext condition to the custom Details step footer, allowing to validate after clicking Next. That way the button is enabled, but gets disabled in the case validation errors and the helper text with the error renders immediately.

[regexowl]

@ezr-ondrej This is what I had in mind in #2305 (comment), what do you think? Would this make sense?

edit: to also add some arguments - this would be consistent with the FSC step, so it's a pattern we already use. The error wouldn't jump at the user prematurely, but at the time when they're happy with how they filled up the step and would like to continue. And this should also be compatible with the "always blue" strategy of Next button being always enabled unless there's a problem that need to be resolved.

[mgold1234]

looks good, just small suggestion

[regexowl]

To continue the discussion we had with @ezr-ondrej #2305 (comment) - does this make sense or not for our use case?

@lucasgarfield @mgold1234 With the way things are set up in PatternFly validation we have two options of showing the user validation errors. This will be specifically for the Details step's Blueprint name input, but there are several places where similar problem occurs (snapshot validation comes to mind):

1. when a non-valid name is entered, we currently disable Next, but an error doesn't get rendered unless the user clicks outside of the input (onBlur). That means user can have the name filled in, can't continue because of disabled button, but doesn't see why.
2. similarly to FSC step we could let the Next button be enabled, but disable it and render an error when the Next button with non-valid name filled in is clicked, which would be this PR.

A fair point is that the always enabled Next even with incorrect values might feel like a bait. On the other hand I feel it's a bit more transparent, but to be honest I'm very much undecided on this. What do you think?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.19%. Comparing base (1a7350e) to head (dbb946a).
Report is 2284 commits behind head on main.

@@            Coverage Diff             @@
##             main    #2392      +/-   ##
==========================================
+ Coverage   75.71%   84.19%   +8.48%     
==========================================
  Files          33      157     +124     
  Lines         597    17734   +17137     
  Branches      144     1764    +1620     
==========================================
+ Hits          452    14931   +14479     
- Misses        139     2782    +2643     
- Partials        6       21      +15     

Files with missing lines	Coverage Δ
...Components/CreateImageWizard/CreateImageWizard.tsx	99.42% <100.00%> (ø)

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8234d3...dbb946a. Read the comment docs.

[regexowl]

/retest

[regexowl]

/retest

[regexowl]

/retest

[mgold1234]

/lgtm

[ezr-ondrej]

Sorry for the delay here, I think this is a sane aproach 👍
Slight disadvantage is that we are still incorrect in some cases (you can't go next, but the button is blue). But it's better then the alternative today - keeping the button disabled even if you could continue and there is just lag.

[regexowl]

Aah right, this will break the IQE tests I guess. 🤔

The original behaviour of Details step when entering an invalid blueprint name was that the Next button got disabled, but no error was rendered.

The new behaviour should be that the Next button is enabled, but when clicking on it the validation kicks in, disables the button and the error gets immediately rendered (when the form is pristine only).

@jrusz @tkoscieln would you have time to take a look at this please? It's not urgent, we'll also probably need to support both scenarios while the changes are soaking in the stage.

[jrusz]

I see a bug with this. When I type an already existing blueprint name, the error is shown but the "Next" button is still enabled. It only gets disabled once clicked on. The test sees that it's enabled, clicks on it and then fails because it expects the Review step to appear.

[github-actions]

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.