Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bib: add new --partition-mode switch to enable lvm #617

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mvo5
Copy link
Collaborator

@mvo5 mvo5 commented Aug 21, 2024

This allows us to quickly enable lvm. Draft as I think we need to decide on the UX, i.e. if this should be done via the blueprint config or commandline or both and how it interacts with --rootfs and btrfs.

This needs:
osbuild/images#876
osbuild/osbuild#1867
osbuild/osbuild#1862

but with that I was able to:

$ bootc-image-builder manifest --partition-mode lvm quay.io/centos-bootc/centos-bootc:stream9
...
$ kvm -m 1500 -cpu host disk.raw
...
localhost login: root
Password: 
[systemd]
Failed Units: 1
  bootc-generic-growpart.service
[root@localhost ~]# mount|grep "/sysroot "
/dev/mapper/rootvg-rootlv on /sysroot type xfs (ro,relatime,seclabel,attr2,inode64,logbufs=8,logbsize=32k,noquota)

@achilleas-k achilleas-k self-requested a review August 21, 2024 16:24
@cgwalters
Copy link
Contributor

Failed Units: 1
  bootc-generic-growpart.service

should be fixed by https://gitlab.com/fedora/bootc/base-images/-/merge_requests/33

@mvo5 mvo5 force-pushed the bib-lv-lg-lol branch 2 times, most recently from c36a4a5 to fc0532a Compare August 28, 2024 05:14
This allows us to quickly enable lvm.
Copy link

github-actions bot commented Oct 6, 2024

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale Issue or PR with no activity for extended period of time label Oct 6, 2024
@mvo5 mvo5 removed the Stale Issue or PR with no activity for extended period of time label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants