bib: drop hardcoding disk UUID #568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current parition_tables.go hardcodes the UUID for the PartitionTable. This is undesired. Drop it so that images generates it automatically and randomly for us. A similar change is probably wanted for images itself and the parition UUIDs.
|
Setting to draft for now for the same reasons as osbuild/images#823 |
cgwalters
added a commit
to cgwalters/bootc-image-builder
that referenced
this pull request
Aug 1, 2024
Closes: osbuild#551 There was a fair amount of copy-paste even when we just had aarch64+x86_64, the addition of duplicate bootfs/rootfs definitions for ppc64le+s390x is a strong motivation to finally define shared constants. I also factored out a shared `const` with some comments for the disk UUID that will save someone some time wondering about it later (this textually but not logically conflicts with osbuild#568 but I think this makes sense to land first). Signed-off-by: Colin Walters <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
Closes: #551 There was a fair amount of copy-paste even when we just had aarch64+x86_64, the addition of duplicate bootfs/rootfs definitions for ppc64le+s390x is a strong motivation to finally define shared constants. I also factored out a shared `const` with some comments for the disk UUID that will save someone some time wondering about it later (this textually but not logically conflicts with #568 but I think this makes sense to land first). Signed-off-by: Colin Walters <[email protected]>
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
|
This PR was closed because it has been stalled for 30+7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current parition_tables.go hardcodes the UUID for the PartitionTable. This is undesired. Drop it so that images generates it automatically and randomly for us.
A similar change is probably wanted for images itself and the parition UUIDs.
[draft as this needs discussion and at lest one test
Also volumeid for vfat needs fixing