drgn.helpers.linux: Add helpers to work with wait-queue(s). #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imran-kn
changed the title
osandov
requested changes
Oct 16, 2023
Thanks for reviewing this. I have integrated your suggestions. |
osandov
requested changes
Oct 25, 2023
drgn/helpers/linux/wait.py
Outdated
| Iterate over all entries in a given wait-queue. | ||
|
|
||
| :param waitq: ``wait_queue_head_t *`` | ||
| :return: Iterator of ``struct wait_queue_entry *`` or ``struct __wait_queue *`` objects. |
There was a problem hiding this comment.
Since you're using the typedef names now, we should document it that way, and also specify why it can be different.
Suggested change
| :return: Iterator of ``struct wait_queue_entry *`` or ``struct __wait_queue *`` objects. | |
| :return: Iterator of ``wait_queue_entry_t *`` or ``wait_queue_t *`` objects | |
| depending on the kernel version. |
There was a problem hiding this comment.
Agree. Although the comment later in the function gives a summary of the change, I have further explained the relation between these 2 typedefs. Please let me know if it looks good or needs any change.
Signed-off-by: Imran Khan <[email protected]>
Signed-off-by: Imran Khan <[email protected]>
osandov
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpers to work with kernel's waitqueue subsystem