libdrgn: fix include-what-you-use warnings

There are a few remaining issues due to
include-what-you-use/include-what-you-use#1569 and
include-what-you-use/include-what-you-use#970, but it's mostly clean
again.

Signed-off-by: Omar Sandoval <[email protected]>

libdrgn/arch_ppc64.c

@@ -4,6 +4,7 @@
 #include <byteswap.h>
 #include <elf.h>
 #include <endian.h>
+#include <stdlib.h>
 #include <string.h>
 
 #include "cleanup.h"

libdrgn/debug_info.h

@@ -12,6 +12,7 @@
 #ifndef DRGN_DEBUG_INFO_H
 #define DRGN_DEBUG_INFO_H
 
+#include <elfutils/libdw.h>
 #include <elfutils/libdwfl.h>
 #include <elfutils/version.h>
 #include <libelf.h>

libdrgn/elf_file.c

@@ -1,9 +1,11 @@
 // Copyright (c) Meta Platforms, Inc. and affiliates.
 // SPDX-License-Identifier: LGPL-2.1-or-later
 
+#include <byteswap.h>
 #include <elf.h>
 #include <gelf.h>
 #include <stdarg.h>
+#include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 

libdrgn/elf_file.h

@@ -12,10 +12,12 @@
 #ifndef DRGN_ELF_FILE_H
 #define DRGN_ELF_FILE_H
 
+#include <elf.h>
 #include <elfutils/libdw.h>
 #include <libelf.h>
 #include <stdbool.h>
 #include <stdint.h>
+#include <stdlib.h>
 
 #include "binary_buffer.h"
 #include "elf_sections.h" // IWYU pragma: export

libdrgn/handler.c

@@ -1,7 +1,6 @@
 // Copyright (c) Meta Platforms, Inc. and affiliates.
 // SPDX-License-Identifier: LGPL-2.1-or-later
 
-#include <stdlib.h>
 #include <string.h>
 
 #include "cleanup.h"

libdrgn/handler.h

@@ -10,7 +10,8 @@
 #ifndef DRGN_HANDLER_H
 #define DRGN_HANDLER_H
 
-#include <stdint.h>
+#include <stdbool.h>
+#include <stdlib.h>
 
 // This should be embedded as the first member in a structure containing the
 // handler implementation.

libdrgn/io.h

@@ -10,6 +10,7 @@
 #ifndef DRGN_IO_H
 #define DRGN_IO_H
 
+#include <stddef.h>
 #include <sys/types.h>
 
 /**

libdrgn/linux_kernel.c

@@ -1,7 +1,6 @@
 // Copyright (c) Meta Platforms, Inc. and affiliates.
 // SPDX-License-Identifier: LGPL-2.1-or-later
 
-#include <byteswap.h>
 #include <dirent.h>
 #include <elf.h>
 #include <elfutils/libdwelf.h>

libdrgn/log.c

@@ -3,7 +3,6 @@
 
 #include <stdarg.h>
 #include <stdio.h>
-#include <unistd.h>
 
 #include "log.h"
 #include "program.h"

libdrgn/object.h

@@ -16,6 +16,7 @@
 #include <string.h>
 
 #include "drgn.h"
+#include "handler.h"
 #include "type.h"
 
 /**

libdrgn/openmp.c

@@ -6,7 +6,6 @@
 #include <stdbool.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <sys/types.h>
 
 #include "cleanup.h"
 #include "hash_table.h"

libdrgn/orc_info.c

@@ -2,6 +2,7 @@
 // SPDX-License-Identifier: LGPL-2.1-or-later
 
 #include <byteswap.h>
+#include <elf.h>
 #include <gelf.h>
 #include <limits.h>
 #include <stdlib.h>

libdrgn/orc_info.h

@@ -13,7 +13,6 @@
 #define DRGN_ORC_INFO_H
 
 #include <stdbool.h>
-#include <stddef.h>
 #include <stdint.h>
 
 #include "cfi.h"

libdrgn/program.c

@@ -6,6 +6,7 @@
 #include <dirent.h>
 #include <elf.h>
 #include <elfutils/libdw.h>
+#include <elfutils/libdwfl.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <gelf.h>
@@ -28,6 +29,7 @@
 #include "linux_kernel.h"
 #include "memory_reader.h"
 #include "minmax.h"
+#include "object.h"
 #include "program.h"
 #include "symbol.h"
 #include "util.h"

libdrgn/program.h

@@ -12,7 +12,6 @@
 #ifndef DRGN_PROGRAM_H
 #define DRGN_PROGRAM_H
 
-#include <elfutils/libdwfl.h>
 #include <libelf.h>
 #include <sys/types.h>
 #ifdef WITH_LIBKDUMPFILE
@@ -27,11 +26,9 @@
 #include "memory_reader.h"
 #include "platform.h"
 #include "pp.h"
-#include "symbol.h"
 #include "type.h"
 #include "vector.h"
 
-struct drgn_type_finder;
 struct drgn_object_finder;
 struct drgn_symbol_finder;
 

libdrgn/python/drgnpy.h

@@ -15,7 +15,6 @@
 #include "../drgn.h"
 // IWYU pragma: end_exports
 
-#include "../hash_table.h"
 #include "../hash_table.h"
 #include "../pp.h"
 #include "../program.h"

libdrgn/python/object.c

@@ -5,7 +5,6 @@
 #include <math.h>
 
 #include "drgnpy.h"
-#include "../cleanup.h"
 #include "../error.h"
 #include "../object.h"
 #include "../serialize.h"

libdrgn/python/program.c

@@ -5,12 +5,13 @@
 #include "../bitops.h"
 #include "../error.h"
 #include "../hash_table.h"
+#include "../linux_kernel.h"
 #include "../log.h"
 #include "../program.h"
 #include "../string_builder.h"
+#include "../symbol.h"
 #include "../util.h"
 #include "../vector.h"
-#include "../linux_kernel.h"
 
 DEFINE_HASH_SET_FUNCTIONS(pyobjectp_set, ptr_key_hash_pair, scalar_key_eq);
 

libdrgn/python/symbol.c

@@ -4,7 +4,6 @@
 #include <inttypes.h>
 
 #include "drgnpy.h"
-#include "../symbol.h"
 
 PyObject *Symbol_wrap(struct drgn_symbol *sym, PyObject *name_obj)
 {

libdrgn/python/type_kind_set.c

@@ -3,6 +3,7 @@
 
 #include "drgnpy.h"
 #include "../bitops.h"
+#include "../util.h"
 
 static PyObject *collections_abc_Set;
 

libdrgn/stack_trace.c

@@ -2,14 +2,13 @@
 // SPDX-License-Identifier: LGPL-2.1-or-later
 
 #include <assert.h>
+#include <elf.h>
 #include <elfutils/libdw.h>
-#include <elfutils/libdwfl.h>
 #include <inttypes.h>
 #include <stdlib.h>
 #include <string.h>
 
 #include "cfi.h"
-#include "cleanup.h"
 #include "debug_info.h"
 #include "drgn.h"
 #include "dwarf_constants.h"

libdrgn/string_builder.h

@@ -15,6 +15,7 @@
 #include <stdarg.h>
 #include <stdbool.h>
 #include <stddef.h>
+#include <stdlib.h>
 #include <string.h>
 
 /**