Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IndexMap in byte_seq_parser macro #438

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Use IndexMap in byte_seq_parser macro #438

merged 1 commit into from
Dec 19, 2024

Conversation

osa1
Copy link
Owner

@osa1 osa1 commented Dec 19, 2024

This make map iteration deterministic and makes tiny builds reproducible.

Fixes #437.

This make map iteration deterministic and makes tiny builds
reproducible.

Fixes #437.
@osa1
Copy link
Owner Author

osa1 commented Dec 19, 2024

The command

  cargo test --no-default-features \
    --features "tls-native desktop-notifications"

Is currently failing on macos-latest. It started a while ago and the run passes if I restart it a few times. We should investigate it separately.

@osa1 osa1 merged commit 075c0bf into master Dec 19, 2024
13 of 14 checks passed
@osa1 osa1 deleted the deterministic_builds branch December 19, 2024 08:24
@bmwiedemann
Copy link

Thanks for the quick patch. I cannot test it easily with my tools because of the added dependency. I expect it to be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reproducible builds problem
2 participants