Skip to content

Commit

Permalink
Move StackCheckLib To a Defined Library Class
Browse files Browse the repository at this point in the history 
Commit tianocore@ac43bba
added StackCheckLibNull to MdeLibs.dsc.inc per review requests on the PR:
tianocore#5957 (comment)
tianocore#5957 (comment)

The PR was adapted to move specifying StackCheckLibNull in every DSC
to MdeLibs.dsc.inc. However, while this works, it does not allow for
a platform to use one of the other StackCheckLibs (such as
StackCheckLibStaticInit) because we get a linker error by having the
compiler defined stack cookie variables defined more than once (once
from StackCheckLibNull in MdeLibs.dsc.inc and the other in the actual
StackCheckLib implementation). Every platform must include MdeLibs.dsc.inc
and there is no way to override a NULL library class.

In order to avoid build breaks, this PR updates all DSCs and relevant
dsc.incs to remove StackCheckLibNull for the CI build. It also changes
it to the StackCheckLib library class in MdeLibs.dsc.inc. StackCheckLib
is added as a LibraryClass dependency to each of the Entry Point libs.

This has been tested that StackCheckLibStaticInit can be used in a
package's CI instead of the null version now.

Continuous-integration-options: PatchCheck.ignore-multi-package

Signed-off-by: Oliver Smith-Denny <[email protected]>
  • Loading branch information
@os-d
os-d committed Sep 19, 2024
1 parent 273f43c commit 6e686d9
Show file tree
Hide file tree
Showing 46 changed files with 19 additions and 128 deletions.
4 changes: 0 additions & 4 deletions ArmPkg/ArmPkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,6 @@

OemMiscLib|ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf

[LibraryClasses.common.SEC]
# ARM platforms have SEC modules with standard entry points, so we can generically link StackCheckLib
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.common.PEIM]
HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
Expand Down
3 changes: 0 additions & 3 deletions ArmPlatformPkg/ArmPlatformPkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,6 @@
MemoryAllocationLib|EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf
PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf

# ARM platforms have SEC modules with standard entry points, so we can generically link StackCheckLib
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.AARCH64.MM_STANDALONE]
HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf
MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAllocationLib/StandaloneMmMemoryAllocationLib.inf
Expand Down
3 changes: 0 additions & 3 deletions ArmVirtPkg/ArmVirt.dsc.inc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,6 @@
DebugLib|ArmVirtPkg/Library/DebugLibFdtPL011Uart/DebugLibFdtPL011UartFlash.inf
!endif

# ARM platforms have SEC modules with standard entry points, so we can generically link StackCheckLib
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.common.PEI_CORE]
PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf
BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
Expand Down
2 changes: 0 additions & 2 deletions CryptoPkg/CryptoPkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,6 @@
[LibraryClasses.common.SEC]
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf
TlsLib|CryptoPkg/Library/TlsLibNull/TlsLibNull.inf
# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.common.PEIM]
PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
Expand Down
4 changes: 0 additions & 4 deletions DynamicTablesPkg/DynamicTablesPkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
[LibraryClasses.common.SEC]
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.ARM, LibraryClasses.AARCH64]
PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf

Expand Down
2 changes: 0 additions & 2 deletions EmbeddedPkg/EmbeddedPkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,6 @@

[LibraryClasses.common.SEC]
ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.ARM, LibraryClasses.AARCH64]
ArmGicLib|ArmPkg/Drivers/ArmGic/ArmGicLib.inf
Expand Down
16 changes: 2 additions & 14 deletions EmulatorPkg/EmulatorPkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,6 @@
PpiListLib|EmulatorPkg/Library/SecPpiListLib/SecPpiListLib.inf
DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf
TimerLib|EmulatorPkg/Library/PeiTimerLib/PeiTimerLib.inf
# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.common.USER_DEFINED, LibraryClasses.common.BASE]
DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
Expand Down Expand Up @@ -322,24 +320,14 @@
# CLANGPDB is cross OS tool chain. It depends on WIN_HOST_BUILD flag
# to build WinHost application.
#
# USER_DEFINED components skip normal NULL lib linking, so we have to link this
# specially here for the libs that have stack guard enabled
##
EmulatorPkg/Win/Host/WinHost.inf {
<LibraryClasses>
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
}
EmulatorPkg/Win/Host/WinHost.inf
!else
##
# Emulator, OS POSIX application
#
# USER_DEFINED components skip normal NULL lib linking, so we have to link this
# specially here for the libs that have stack guard enabled
##
EmulatorPkg/Unix/Host/Host.inf {
<LibraryClasses>
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
}
EmulatorPkg/Unix/Host/Host.inf
!endif
!endif

Expand Down
2 changes: 1 addition & 1 deletion EmulatorPkg/Library/PeiEmuPeCoffGetEntryPointLib/PeiEmuPeCoffGetEntryPointLib.inf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
[LibraryClasses]
PeiServicesLib
DebugLib

StackCheckLib

[Ppis]
gEmuThunkPpiGuid # PPI ALWAYS_CONSUMED
Expand Down
4 changes: 0 additions & 4 deletions FatPkg/FatPkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@
DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
[LibraryClasses.common.SEC]
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.common.PEIM]
PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
Expand Down
4 changes: 0 additions & 4 deletions FmpDevicePkg/FmpDevicePkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,6 @@
FmpDependencyDeviceLib|FmpDevicePkg/Library/FmpDependencyDeviceLibNull/FmpDependencyDeviceLibNull.inf
TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
[LibraryClasses.common.SEC]
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.ARM]
ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf

Expand Down
4 changes: 0 additions & 4 deletions IntelFsp2Pkg/IntelFsp2Pkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@
FspSecPlatformLib|IntelFsp2Pkg/Library/SecFspSecPlatformLibNull/SecFspSecPlatformLibNull.inf
FspMultiPhaseLib|IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/BaseFspMultiPhaseLib.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
[LibraryClasses.common.SEC]
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.common.PEIM, LibraryClasses.common.SEC]
PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf
Expand Down
4 changes: 0 additions & 4 deletions IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@

Tpm2CommandLib|SecurityPkg/Library/Tpm2CommandLib/Tpm2CommandLib.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
[LibraryClasses.common.SEC]
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.common.PEIM,LibraryClasses.common.PEI_CORE]
PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
Expand Down
4 changes: 0 additions & 4 deletions MdeModulePkg/MdeModulePkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,6 @@
IpmiCommandLib|MdeModulePkg/Library/BaseIpmiCommandLibNull/BaseIpmiCommandLibNull.inf
SpiHcPlatformLib|MdeModulePkg/Library/BaseSpiHcPlatformLibNull/BaseSpiHcPlatformLibNull.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
[LibraryClasses.common.SEC]
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.EBC.PEIM]
IoLib|MdePkg/Library/PeiIoLibCpuIo/PeiIoLibCpuIo.inf

Expand Down
1 change: 1 addition & 0 deletions MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,5 @@

[LibraryClasses]
DebugLib
StackCheckLib

1 change: 1 addition & 0 deletions MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,5 @@
[LibraryClasses]
BaseLib
DebugLib
StackCheckLib

1 change: 1 addition & 0 deletions MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,5 @@
[LibraryClasses]
BaseLib
DebugLib
StackCheckLib

1 change: 1 addition & 0 deletions MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,5 @@

[LibraryClasses]
DebugLib
StackCheckLib

1 change: 1 addition & 0 deletions MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
BaseLib
DebugLib
MmServicesTableLib
StackCheckLib

[Protocols]
gEfiLoadedImageProtocolGuid ## SOMETIMES_CONSUMES
1 change: 1 addition & 0 deletions MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,5 @@
UefiBootServicesTableLib
DebugLib
BaseLib
StackCheckLib

1 change: 1 addition & 0 deletions MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
UefiBootServicesTableLib
DebugLib
BaseLib
StackCheckLib


[Protocols]
Expand Down
7 changes: 1 addition & 6 deletions MdePkg/MdeLibs.dsc.inc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblockMemoryLibNull.inf
StackCheckLib|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.ARM, LibraryClasses.AARCH64]
#
Expand All @@ -30,9 +31,3 @@
# definitions for the intrinsic functions.
#
NULL|MdePkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf

# Stack Cookies cannot be generically applied to SEC modules because they may not define _ModuleEntryPoint and when we
# link a library in, we have to be able to define the entry point. SEC modules that do define _ModuleEntryPoint can
# apply a library class override to get StackCheckLibNull.inf
[LibraryClasses.common.PEI_CORE, LibraryClasses.common.PEIM, LibraryClasses.common.DXE_CORE, LibraryClasses.common.SMM_CORE, LibraryClasses.common.MM_CORE_STANDALONE, LibraryClasses.common.DXE_DRIVER, LibraryClasses.common.DXE_RUNTIME_DRIVER, LibraryClasses.common.DXE_SMM_DRIVER, LibraryClasses.common.MM_STANDALONE, LibraryClasses.common.UEFI_DRIVER, LibraryClasses.common.UEFI_APPLICATION]
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
4 changes: 0 additions & 4 deletions NetworkPkg/NetworkPkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,6 @@
FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
[LibraryClasses.common.SEC]
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.common.UEFI_DRIVER]
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
Expand Down
3 changes: 0 additions & 3 deletions OvmfPkg/AmdSev/AmdSevX64.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,6 @@
CcExitLib|OvmfPkg/Library/CcExitLib/SecCcExitLib.inf
MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptSevLib.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.common.PEI_CORE]
HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf
Expand Down
3 changes: 0 additions & 3 deletions OvmfPkg/Bhyve/BhyveX64.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,6 @@
CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.inf
MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptSevLib.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.common.PEI_CORE]
HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf
Expand Down
3 changes: 0 additions & 3 deletions OvmfPkg/CloudHv/CloudHvX64.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -269,9 +269,6 @@
CcExitLib|OvmfPkg/Library/CcExitLib/SecCcExitLib.inf
MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptSevLib.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.common.PEI_CORE]
HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf
Expand Down
3 changes: 0 additions & 3 deletions OvmfPkg/IntelTdx/IntelTdxX64.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,6 @@
PeilessStartupLib|OvmfPkg/Library/PeilessStartupLib/PeilessStartupLib.inf
CcProbeLib|OvmfPkg/Library/CcProbeLib/SecPeiCcProbeLib.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.common.DXE_CORE]
HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf
Expand Down
1 change: 1 addition & 0 deletions ...Pkg/Library/UefiDriverEntryPointFwCfgOverrideLib/UefiDriverEntryPointFwCfgOverrideLib.inf
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
DebugLib
QemuFwCfgSimpleParserLib
UefiBootServicesTableLib
StackCheckLib

[Protocols]
gEfiLoadedImageProtocolGuid ## SOMETIMES_CONSUMES
Expand Down
3 changes: 0 additions & 3 deletions OvmfPkg/LoongArchVirt/LoongArchVirtQemu.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,6 @@
PlatformHookLib | OvmfPkg/LoongArchVirt/Library/Fdt16550SerialPortHookLib/EarlyFdt16550SerialPortHookLib.inf
CpuExceptionHandlerLib | UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
NULL | MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.common.PEI_CORE]
PcdLib | MdePkg/Library/PeiPcdLib/PeiPcdLib.inf
HobLib | MdePkg/Library/PeiHobLib/PeiHobLib.inf
Expand Down
3 changes: 0 additions & 3 deletions OvmfPkg/Microvm/MicrovmX64.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,6 @@
CcExitLib|OvmfPkg/Library/CcExitLib/SecCcExitLib.inf
MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/SecMemEncryptSevLib.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.common.PEI_CORE]
HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf
Expand Down
1 change: 0 additions & 1 deletion OvmfPkg/OvmfPkgIa32.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,6 @@
OvmfPkg/Sec/SecMain.inf {
<LibraryClasses>
NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
}

#
Expand Down
1 change: 0 additions & 1 deletion OvmfPkg/OvmfPkgIa32X64.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,6 @@
OvmfPkg/Sec/SecMain.inf {
<LibraryClasses>
NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
}

#
Expand Down
1 change: 0 additions & 1 deletion OvmfPkg/OvmfPkgX64.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,6 @@
NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
NULL|OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelperLib.inf
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
}

#
Expand Down
1 change: 0 additions & 1 deletion OvmfPkg/OvmfXen.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,6 @@
OvmfPkg/Sec/SecMain.inf {
<LibraryClasses>
NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf
}

#
Expand Down
3 changes: 0 additions & 3 deletions OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,6 @@
PrePiHobListPointerLib|OvmfPkg/RiscVVirt/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf
MemoryAllocationLib|EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.common.DXE_CORE]
PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf
HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
Expand Down
4 changes: 0 additions & 4 deletions PcAtChipsetPkg/PcAtChipsetPkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@
ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
[LibraryClasses.common.SEC]
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[Components]
PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf
PcAtChipsetPkg/Bus/Pci/IdeControllerDxe/IdeControllerDxe.inf
Expand Down
4 changes: 0 additions & 4 deletions PrmPkg/PrmPkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@
UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
[LibraryClasses.common.SEC]
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.IA32, LibraryClasses.X64]
MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf

Expand Down
4 changes: 0 additions & 4 deletions RedfishPkg/RedfishPkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,6 @@
IpmiLib|MdeModulePkg/Library/BaseIpmiLibNull/BaseIpmiLibNull.inf
IpmiCommandLib|MdeModulePkg/Library/BaseIpmiCommandLibNull/BaseIpmiCommandLibNull.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
[LibraryClasses.common.SEC]
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.ARM, LibraryClasses.AARCH64]
ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf

Expand Down
4 changes: 0 additions & 4 deletions SecurityPkg/SecurityPkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,6 @@
PlatformLibWrapper|SecurityPkg/DeviceSecurity/OsStub/PlatformLibWrapper/PlatformLibWrapper.inf
MemLibWrapper|SecurityPkg/DeviceSecurity/OsStub/MemLibWrapper/MemLibWrapper.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
[LibraryClasses.common.SEC]
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[LibraryClasses.ARM, LibraryClasses.AARCH64]
ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf

Expand Down
4 changes: 0 additions & 4 deletions ShellPkg/ShellPkg.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,6 @@
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf

# StackCheckLib is not linked for SEC modules by default, this package can link it against its SEC modules
[LibraryClasses.common.SEC]
NULL|MdePkg/Library/StackCheckLibNull/StackCheckLibNull.inf

[PcdsFixedAtBuild]
gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xFF
gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|16000
Expand Down
Loading

0 comments on commit 6e686d9

Please sign in to comment.