Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make isotovideo workflows more GitHub Native #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make isotovideo workflows more GitHub Native #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c54933b
Skip job openQA if credentials are not configured
josegomezr Dec 6, 2023
ed4c006
Make isotovideo workflows more GitHub Native
josegomezr Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions .github/workflows/isotovideo-action.yml
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions .github/workflows/isotovideo-check-all-test-modules.yml
View file
Open in desktop

This file was deleted.

42 changes: 37 additions & 5 deletions .github/workflows/isotovideo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,43 @@
---
name: isotovideo
# yamllint disable-line rule:truthy
on: [push, pull_request]
on:
- push
- pull_request
jobs:
test:
isotovideo:
strategy:
matrix:
# An example matrix, it'll create a derivate job for each
# item specified here. For simplicity sake the example below
# has the full var line since it's easy enough.
#
# For more complex setups it'll be worth exploring advance matrix setups
# see: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#example-expanding-configurations
isotovideo-args:
- "--exit-status-from-test-results qemu_no_kvm=1 casedir=."
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Run isotovideo against test code in happy-path scenario
run: podman run --rm -it -v .:/tests:Z registry.opensuse.org/devel/openqa/containers/isotovideo:qemu-x86 qemu_no_kvm=1 casedir=/tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained in #28 on multiple places, in particular #28 (comment) , I am not convinced we should do that change from a single podman call to a github workflow specific syntax. There are of course some advantages but as disadvantages I see that people can not just copy-paste that line to reproduce. I would go even further and extract that line into a Makefile so that github CI same as users can just call make test-isotovideo-happy-path without duplication.

- uses: actions/checkout@v4

- name: Run isotovideo against test code
uses: "docker://registry.opensuse.org/devel/openqa/containers/isotovideo:qemu-x86"
with:
args: ${{ matrix.isotovideo-args }} ${{ env.ACTIONS_STEP_DEBUG && '--debug' || '' }}
entrypoint: 'isotovideo'

- name: Archive test artifcats
if: always()
uses: actions/upload-artifact@v3
with:
name: isotovideo-artifacts
path: |
./testresults/
./video.ogv
./video_time.vtt
./qemu_state.json
./serial_terminal.txt
./virtio_console.log
./virtio_console1.log
./virtio_console_user.log
retention-days: 7
6 changes: 4 additions & 2 deletions .github/workflows/openqa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,12 @@ jobs:
runs-on: ubuntu-latest
container:
image: registry.opensuse.org/devel/openqa/containers/tumbleweed:client
if: ${{ env.OPENQA_API_KEY && env.OPENQA_API_SECRET }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Trigger and monitor openQA test
run: >
id: openqa_schedule
run: |
openqa-cli schedule \
--monitor \
--host "${OPENQA_HOST:-https://openqa.opensuse.org}/" \
Expand Down
Loading