Avoid blocking openQA jobs on Git updates #6055
Open
+68
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `search(…)->delete` to delete tasks using a single query if possible * Use signatures in relevant functions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6055 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 395 395
Lines 39452 39481 +29
=======================================
+ Hits 39052 39081 +29
Misses 400 400 ☔ View full report in Codecov by Sentry. |
okurz
requested changes
Nov 12, 2024
* Unblock openQA jobs if Git updates failed for two times
* Change the behavior with `git_auto_update = yes` to be more like it
was with the `fetchneedles` approach (that also did not block jobs in
case of failures)
* Avoid running into timeouts in openQA-in-openQA tests which expect
jobs to be scheduled in a more timely manner, see
https://progress.opensuse.org/issues/169204
* Keep blocking openQA jobs if any of the repositories required by the
scheduled jobs was explicitly specified
* Fix "analogous" * Rewrite comment containing misspelled "referrers"
The starting point for the previous commit "Avoid blocking openQA jobs on Git updates" were network-related issues, see https://progress.opensuse.org/issues/169204. So it makes sense to limit it to network-related changes.
Martchus
force-pushed
the
non-fatal-auto-update
branch
from
49cc25b
to
e2fc65d
Compare
okurz
approved these changes
Nov 13, 2024
kalikiana
reviewed
Nov 13, 2024
| combined_like { $minion->foreground($job->id) } qr/fake disconnect/, 'error logged'; | ||
| is $job->info->{state}, 'failed', 'job failed for real after retries exhausted'; | ||
| } | ||
| if $gru_task; |
There was a problem hiding this comment.
Looks like the unit test never sets git_auto_update_method so strict is not tested?
There was a problem hiding this comment.
That's true. Just like we never test for "no" in "yes"/"no" settings. Everything that is not "yes" is simply "no". And here it is similar, so everything that is not "best-effort" is "strict". I could of course add some kind of validation in the config parser and print a warning for invalid values. (That's not how we usually handle this, though.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git_auto_update = yesto be more like itwas with the
fetchneedlesapproach (that also did not block jobs incase of failures)
jobs to be scheduled in a more timely manner, see
https://progress.opensuse.org/issues/169204
scheduled jobs was explicitly specified
Still a draft as I still need to restrict it to network issues.