Add option to restart jobs upon comment submission

[b10n1k]

Refactor restartJob in order to make sure that is able to handle request for
multiple restarts. This follows up with some changes to the form and the
javascript part of the overview.html.ep, which triggers the restart with the
use of restartJob, as opposed of reimplement the logic.
The advantage is that we have one common behavior and error handling on the
restart operation.

• An optional comment can be passed not to restartJob, which is included to
  the request.

• restartJob handles both single and multible job restarts.

• The form is designed to handle each occasion in separate functions making
  the code becomes more modular and easier to maintain.

• The overvies's restartJobs function will restart only jobs with valid id.- Renamed addComments to bulkJobsAction to handle both commenting and restarting jobs.

• Updated HTML to include "Restart and Comment" and "Comment" buttons with individual data URLs.

These updates enhance the user experience by allowing users to either comment on jobs, or perform restart with a comment simultaneously from the overview page. Comments always add to the original job of the overview page. By integrating this functionality we provide a workflow for users managing multiple jobs on the overview page.

https://progress.opensuse.org/issues/166559

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (ebe44db) to head (29fdf01).
Report is 15 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5971   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         395      395           
  Lines       39417    39428   +11     
=======================================
+ Hits        39017    39028   +11     
  Misses        400      400           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[b10n1k]

please describe the relation to

• Add option to restart jobs upon comment submission #5946

The difference between this PR and the previews is that the old PR solves the problem integrating the logic in the Comments.pm passing parameters in the underline function.
It was requested to implement the solution using the Job.pm. This is not the case in this PR though.

[Martchus]

You could base your PR on #5981 but it looks like I'll have to put a little bit more work into it (as CI checks are currently failing).

[b10n1k]

UPDATED screenshot

**

**

[b10n1k]

Some comments on 717e152

• Review commit message for main changes
• not sure if we prefer to rename the restartJob in openqa.js
• not sure if we prefer to provide a link for reload as it is for comments submittion. I went with auto reload for now
• I havent writen any additional tests as for now, other than the ones from the previous commit

[Martchus]

Suggested change

	setTimeout(() => {
	window.location.reload();
	}, 2000);
	setTimeout(() => window.location.reload(), 2000);

Although I don't like this whole approach of first adding an info to only reload the whole page 2 seconds later anyway. I would rather not reload the page automatically and change the info to "Changes have been applied. You may reload the page." where "reload" is a link that will reload the page. This way the info contains more useful information and one has more than 2 seconds to read it.

[kalikiana]

What's the benefit of having time to read that a reload is required? Why not just reload right away?

[b10n1k]

I changed to the manual reload with a similar text as it is for comments

[Martchus]

I don't see that this has been updated. As-is it looks like you still can't decide whether to reload the page or show a notification.

I suggest to show a notification. Only this way it is apparent that the operation was actually successful. Otherwise the page is just reloading but the user has to interpret this behavior as success - which is not ideal in my opinion. The notification should also explicitly list of jobs that have actually been successfully restarted so one can easily go though the list to access them if wanted. It can of course also include a link for reloading the page.

[b10n1k]

My mistake. I did the changes but I revert the file in some point after experiment with the progress bar. I have to check again that your previews comments are also here.

[Martchus]

We normally start test names with lower case. You can also drop the "is right" in the end which is kind of a given for checks:

Suggested change

	'1 unfinished', 'The number of unfinished jobs is right');
	'1 unfinished', 'expected number of unfinished jobs');

EDIT: I now see that you're just moving this code. My suggestion would nevertheless be a good improvement.

[kalikiana]

@b10n1k How about this one?

[kalikiana]

Not changed in the latest diff. Ofc you can argue that you don't want to change it. Be explicit, though, rather than leaving questions unanswered.

[b10n1k]

Done

[github-actions]

Great PR! Please pay attention to the following items before merging:

Files matching assets/stylesheets/**:

• Consider providing screenshots in a PR comment to show the difference visually

This is an automatically generated QA checklist based on modified files.

[Martchus]

I don't see that this has been updated. As-is it looks like you still can't decide whether to reload the page or show a notification.

I suggest to show a notification. Only this way it is apparent that the operation was actually successful. Otherwise the page is just reloading but the user has to interpret this behavior as success - which is not ideal in my opinion. The notification should also explicitly list of jobs that have actually been successfully restarted so one can easily go though the list to access them if wanted. It can of course also include a link for reloading the page.