Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ts): add client helper functions to SDK #373

Merged
merged 7 commits into from
Sep 18, 2024
Merged

feat(ts): add client helper functions to SDK #373

merged 7 commits into from
Sep 18, 2024

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Aug 1, 2024
@jonas-jonas jonas-jonas marked this pull request as ready for review September 18, 2024 12:07
aeneasr
aeneasr reviewed Sep 18, 2024
View reviewed changes
scripts/generate.sh Outdated Show resolved Hide resolved
aeneasr
aeneasr approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for my one comment

@jonas-jonas jonas-jonas merged commit 6fb21b4 into master Sep 18, 2024
1 check passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/oryClientHelpers branch September 18, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr approved these changes

Assignees

@jonas-jonas jonas-jonas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonas-jonas @aeneasr