Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable discriminator lookup for java #352

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

WoodyWoodsta
Copy link
Contributor

Adds discriminator lookups for Java oneOf specs. This fixes an issue where the oneOf specs weren't being automatically discriminated.

Related Issue or Design Document

Fixes ory/kratos#3807

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2024

CLA assistant check
All committers have signed the CLA.

@aeneasr
Copy link
Member

aeneasr commented Apr 29, 2024

Awesome, nice find!

@aeneasr aeneasr merged commit 0278f60 into ory:master Apr 29, 2024
2 checks passed
@WoodyWoodsta
Copy link
Contributor Author

Thanks @aeneasr. What is the release schedule of the java sdk? (i.e. when can we expect this change to be published?)

@aeneasr
Copy link
Member

aeneasr commented Apr 29, 2024

The client SDK for Ory Network is released almost every time we release to Ory Network. For Ory OSS we release SDKs alongside releases for the projects

@WoodyWoodsta
Copy link
Contributor Author

Even for an inop SDK? We'll have to sort out our own Maven repo or do something locally then :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kratos Java client 1.1.0 throws exception on parsing response from updateRegistrationFlow
3 participants