Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade java generator to version 7.3.0 #332

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

MalteBellmann
Copy link
Contributor

Related Issue or Design Document

fixes ory/hydra-client-java#19

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@aeneasr
Copy link
Member

aeneasr commented Mar 4, 2024

Thank you! We need to make sure the dependencies work correctly - do you have an idea how to test that?

@MalteBellmann
Copy link
Contributor Author

When updating the pom.xml files, i ran ./scripts/generate.sh and ./scripts/test.sh in a oryd/sdk:v0.0.51 docker container, this worked fine. And, if i understand it correctly, these will also run on CI once merged to master (or at the next spec update). I also tested the hydra client locally in my project, also worked fine.

A better solution would probably be integration tests in this or another repository that use the generated clients with an instance of the respective service, do you guys have such a setup?

@aeneasr
Copy link
Member

aeneasr commented Mar 24, 2024

Thank you! :)

@aeneasr aeneasr merged commit bc869c1 into ory:master Mar 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot deserialize API response
2 participants