Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update OpenAPI Generator to 6.1.0 for dotnet to support Blazor WebAssembly #300

Closed
wants to merge 2 commits into from

Conversation

sbward
Copy link

@sbward sbward commented Oct 27, 2023

Related Issue or Design Document

#299

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

.NET Blazor WebAssembly projects must use HttpClient for web requests, however Ory SDK is using a version of OpenAPI Generator (5.4.1) which generates code using RestSharp 106.13.0, which is does not use HttpClient.

Using RestSharp 107+ fixes the issue, and OpenAPI Generator adopts a recent enough version of RestSharp (108.0.3) in version 6.1.0.

RestSharp 107 was a breaking change which drops support for .NET 4.5 (which is no longer supported by Microsoft). For more details see: https://github.com/restsharp/RestSharp/releases/tag/107.0.0

@sbward sbward changed the title Update OpenAPI Generator to 6.1.0 for dotnet Fix: Update OpenAPI Generator to 6.1.0 for dotnet Oct 27, 2023
@sbward sbward changed the title Fix: Update OpenAPI Generator to 6.1.0 for dotnet fix: Update OpenAPI Generator to 6.1.0 for dotnet Oct 27, 2023
@sbward sbward changed the title fix: Update OpenAPI Generator to 6.1.0 for dotnet fix: update OpenAPI Generator to 6.1.0 for dotnet Oct 27, 2023
@sbward sbward changed the title fix: update OpenAPI Generator to 6.1.0 for dotnet fix: update OpenAPI Generator to 6.1.0 for dotnet to support Blazor WebAssembly Oct 27, 2023
scripts/generate.sh Outdated Show resolved Hide resolved
@aeneasr
Copy link
Member

aeneasr commented Mar 24, 2024

Upgraded to 7.4.0 on master :)

@aeneasr aeneasr closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants