Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change distroless to base [Do not merge yet] #1123

Closed
wants to merge 3 commits into from

Conversation

Demonsthere
Copy link
Contributor

Related issue(s)

This PR changes the minimal static image to base, which includes a simple shell.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #1123 (8bafbae) into master (75eb682) will not change coverage.
The diff coverage is n/a.

❗ Current head 8bafbae differs from pull request most recent head 5b70f34. Consider uploading reports for the commit 5b70f34 to get more accurate results

@@           Coverage Diff           @@
##           master    #1123   +/-   ##
=======================================
  Coverage   78.22%   78.22%           
=======================================
  Files          80       80           
  Lines        3863     3863           
=======================================
  Hits         3022     3022           
  Misses        566      566           
  Partials      275      275           

@Demonsthere Demonsthere enabled auto-merge (squash) July 25, 2023 06:53
@Demonsthere Demonsthere marked this pull request as draft July 25, 2023 07:21
auto-merge was automatically disabled July 25, 2023 07:21

Pull request was converted to draft

@Demonsthere Demonsthere changed the title fix: change distroless to base fix: change distroless to base [Do not merge yet] Jul 25, 2023
@@ -1,4 +1,4 @@
FROM gcr.io/distroless/static-debian11:nonroot
FROM gcr.io/distroless/static-debian11:debug-nonroot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a big confusing because the "prod" image is now the debug image. Shouldn't this be a dedicated tag?

@Demonsthere
Copy link
Contributor Author

Closing as not needed after discussion

@Demonsthere Demonsthere deleted the fix/distroless-base branch July 25, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants