refactor: optimize identity related indices #4173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
commented
Oct 24, 2024
| @@ -956,11 +956,11 @@ func (p *IdentityPersister) ListIdentities(ctx context.Context, params identity. | |||
| // important to normalize the identifier before querying the database. | |||
|
|
|||
| joins = params.TransformStatement(` | |||
| INNER JOIN identity_credentials ic ON ic.identity_id = identities.id | |||
| INNER JOIN identity_credential_identifiers ici ON ici.identity_credential_id = ic.id`) | |||
| INNER JOIN identity_credentials ic ON ic.identity_id = identities.id AND ic.nid = identities.nid | |||
There was a problem hiding this comment.
- This will need an update in our overrides @arekkas
aeneasr
commented
Oct 24, 2024
...ence/sql/migrations/sql/20241023142500000001_drop_unused_indices_identity_credentials.up.sql
Outdated
Show resolved
Hide resolved
aeneasr
commented
Oct 24, 2024
...ence/sql/migrations/sql/20241023142500000001_drop_unused_indices_identity_credentials.up.sql
Outdated
Show resolved
Hide resolved
aeneasr
commented
Oct 24, 2024
persistence/sql/migrations/sql/20241023142500000002_drop_unused_indices_sessions.up.sql
Outdated
Show resolved
Hide resolved
alnr
reviewed
Oct 24, 2024
.../sql/migrations/sql/20241023142500000003_drop_unused_indices_credential_identifiers.down.sql
Outdated
Show resolved
Hide resolved
alnr
reviewed
Oct 24, 2024
aeneasr
changed the title
This patch changes sorting to improve performance on list session endpoints. It also removes the `x-total-count` header from list responses. BREAKING CHANGE: The total count header `x-total-count` will no longer be sent in response to `GET /admin/sessions` requests. Closes ory-corp/cloud#7177
aeneasr
force-pushed
the
remove-unused-indices-nidid
branch
from
1b8c016 to
f6ece1a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4173 +/- ##
==========================================
- Coverage 78.57% 78.56% -0.02%
==========================================
Files 379 379
Lines 27042 27033 -9
==========================================
- Hits 21249 21239 -10
+ Misses 4181 4180 -1
- Partials 1612 1614 +2 ☔ View full report in Codecov by Sentry. |
alnr
approved these changes
Oct 29, 2024
malosayli
pushed a commit
to nayla-finance/kratos
that referenced
this pull request
Nov 6, 2024
…indices (ory#4173) This patch changes sorting to improve performance on list session endpoints. It also removes the `x-total-count` header from list responses. BREAKING CHANGE: The total count header `x-total-count` will no longer be sent in response to `GET /admin/sessions` requests. Closes https://github.com/ory-corp/cloud/issues/7177 Closes https://github.com/ory-corp/cloud/issues/7175 Closes https://github.com/ory-corp/cloud/issues/7176
malosayli
pushed a commit
to nayla-finance/kratos
that referenced
this pull request
Nov 6, 2024
…indices (ory#4173) This patch changes sorting to improve performance on list session endpoints. It also removes the `x-total-count` header from list responses. BREAKING CHANGE: The total count header `x-total-count` will no longer be sent in response to `GET /admin/sessions` requests. Closes https://github.com/ory-corp/cloud/issues/7177 Closes https://github.com/ory-corp/cloud/issues/7175 Closes https://github.com/ory-corp/cloud/issues/7176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments