Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update broken links in CONTRIBUTING.md #3929

Closed
wants to merge 1 commit into from
Closed

docs: update broken links in CONTRIBUTING.md #3929

wants to merge 1 commit into from

Conversation

jacwil
Copy link
Contributor

@jacwil jacwil commented May 19, 2024

Broken links make it more difficult to contribute.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

@jacwil jacwil requested review from aeneasr, zepatrik and hperl as code owners May 19, 2024 04:18
Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.05%. Comparing base (1a9a096) to head (ba86b9a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3929      +/-   ##
==========================================
- Coverage   78.07%   78.05%   -0.02%     
==========================================
  Files         362      362              
  Lines       25341    25341              
==========================================
- Hits        19785    19781       -4     
- Misses       4039     4044       +5     
+ Partials     1517     1516       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The correct place to update this is here: https://github.com/ory/meta/blob/master/templates/repository/common/CONTRIBUTING.md :)

@jacwil
Copy link
Contributor Author

jacwil commented May 21, 2024

Abandoning this PR to update the correct repo.

@jacwil jacwil closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants