-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: log external latency #3868
base: master
Are you sure you want to change the base?
Conversation
…cy-metric # Conflicts: # selfservice/hook/web_hook.go
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3868 +/- ##
==========================================
+ Coverage 78.04% 78.08% +0.04%
==========================================
Files 360 361 +1
Lines 25276 25274 -2
==========================================
+ Hits 19726 19736 +10
+ Misses 4038 4025 -13
- Partials 1512 1513 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment.
With this change, we measure and log some external latency separately.
Right now, we consider this external:
Other calls, like loading jsonnet or courier templates, are not considered external because they are tightly coupled to the server Kratos is running on.