fix: remove unnecessary COPY command from Dockerfile

[osbornk]

The .docker/Dockerfile-build has a COPY command that does not match any files.

COPY internal/httpclient/go.* internal/httpclient/

There are no files that match internal/httpclient/go.*.

ls internal/httpclient/go.*
zsh: no matches found: internal/httpclient/go.*

In some systems (Podman, Skaffold) that causes problems. Each of these commands produces a layer. In the case of Skaffold, it is unable to match this layer from the cache and then exits with an error.

The workaround with Skaffold is to disable caching. That creates a successful Docker image, but slows down the build process significantly.

Removing this line allowed Skaffold to build an image successfully with caching. It also produces a fully functional image.

Related issue(s)

#3446

Checklist

• I have read the contributing guidelines.
• I have referenced an issue containing the design document if my change
  introduces a new feature.
• I am following the
  contributing code guidelines.
• I have read the security policy.
• I confirm that this pull request does not address a security
  vulnerability. If this pull request addresses a security vulnerability, I
  confirm that I got the approval (please contact
  [email protected]) from the maintainers to push
  the changes.
• I have added tests that prove my fix is effective or that my feature
  works.
• I have added or changed the documentation.

Further Comments

[CLAassistant]

All committers have signed the CLA.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5f39f4) 78.36% compared to head (c5f39f4) 78.36%.

❗ Current head c5f39f4 differs from pull request most recent head 6e74213. Consider uploading reports for the commit 6e74213 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3771   +/-   ##
=======================================
  Coverage   78.36%   78.36%           
=======================================
  Files         348      348           
  Lines       23999    23999           
=======================================
  Hits        18807    18807           
  Misses       3772     3772           
  Partials     1420     1420           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.