Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tests on master #3737

Merged
merged 3 commits into from
Feb 5, 2024
Merged

chore: fix tests on master #3737

merged 3 commits into from
Feb 5, 2024

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Feb 5, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl self-assigned this Feb 5, 2024
jonas-jonas
jonas-jonas previously approved these changes Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67360cf) 78.33% compared to head (b2889b5) 78.33%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3737   +/-   ##
=======================================
  Coverage   78.33%   78.33%           
=======================================
  Files         347      347           
  Lines       23804    23808    +4     
=======================================
+ Hits        18646    18650    +4     
  Misses       3749     3749           
  Partials     1409     1409           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr enabled auto-merge (squash) February 5, 2024 14:12
@aeneasr aeneasr merged commit 12166b4 into master Feb 5, 2024
24 checks passed
@aeneasr aeneasr deleted the hperl/fix-master branch February 5, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants