Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: list by OIDC cred #3721

Merged
merged 3 commits into from
Feb 2, 2024
Merged

feat: list by OIDC cred #3721

merged 3 commits into from
Feb 2, 2024

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Jan 30, 2024

Related issue(s)

Fixes #3333

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested review from alnr and jonas-jonas January 30, 2024 13:08
@hperl hperl self-assigned this Jan 30, 2024
@hperl hperl force-pushed the hperl/list-by-oidc-cred branch from 726e0bd to d12911c Compare January 30, 2024 15:30
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (549308d) 78.34% compared to head (51692ea) 78.32%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3721      +/-   ##
==========================================
- Coverage   78.34%   78.32%   -0.03%     
==========================================
  Files         347      347              
  Lines       23765    23769       +4     
==========================================
- Hits        18619    18617       -2     
- Misses       3743     3749       +6     
  Partials     1403     1403              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hperl hperl requested a review from aeneasr January 31, 2024 07:22
@aeneasr aeneasr merged commit bff9c61 into master Feb 2, 2024
@aeneasr aeneasr deleted the hperl/list-by-oidc-cred branch February 2, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List identities by oidc identifier
2 participants