Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: expand test suite for verification + OAuth challenge #3720

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Jan 30, 2024

Related issue(s)

Resolves https://github.com/ory-corp/cloud/issues/5633

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from jonas-jonas January 30, 2024 10:40
@hperl hperl self-assigned this Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90bdc61) 78.30% compared to head (9236e89) 78.26%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3720      +/-   ##
==========================================
- Coverage   78.30%   78.26%   -0.05%     
==========================================
  Files         347      347              
  Lines       23804    23804              
==========================================
- Hits        18640    18630      -10     
- Misses       3755     3764       +9     
- Partials     1409     1410       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hperl hperl force-pushed the hperl/verification-testsuite branch from 9069733 to 9236e89 Compare January 30, 2024 16:39
@hperl hperl merged commit 67360cf into master Jan 31, 2024
29 checks passed
@hperl hperl deleted the hperl/verification-testsuite branch January 31, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants