feat: webhooks support setting client cookies #3716
+80
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
None- I've added this without any prior discussion.
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
Hey folks, it's been a while 👋 Hope you all had a good winter break!
My team realized it would be helpful if we could set an additional cookie via the post-login webhook for some of our users, and so I went ahead and added support for doing just that 😁 This PR is a functional proof of concept.
A webhook response with the following would set a cookie named "foo" with the value "bar":
As I see it, the only remaining work this branch needs is:
Before working on that though, I wanted to check in with you guys first to see if this is a feature you'd be interested in merging.