Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: csrf token regenerate on browser flows #3706

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix: csrf token regenerate on browser flows #3706

merged 1 commit into from
Jan 19, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jan 19, 2024

Closes #3705

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (688111c) 78.31% compared to head (a36f095) 78.35%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3706      +/-   ##
==========================================
+ Coverage   78.31%   78.35%   +0.03%     
==========================================
  Files         346      346              
  Lines       23570    23571       +1     
==========================================
+ Hits        18459    18468       +9     
+ Misses       3717     3710       -7     
+ Partials     1394     1393       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit e4908db into master Jan 19, 2024
30 checks passed
@aeneasr aeneasr deleted the fix-csrf branch January 19, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants