Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify hydra email verfication problem #3703

Closed
wants to merge 1 commit into from
Closed

Conversation

kghost
Copy link

@kghost kghost commented Jan 19, 2024

Note: This is not a fix, this is a POC to identify the problem

Related issue(s)

#3358
#3320

Problem: When completing a sign up coming from hydra (registration flow with login_challenge), even with show_verification_ui configured in post registrition hook, it doesn't jump to verfication page, but logined to hydra direct, and succesfully grant an oauth2 token.

This breaks our security model which relies our private email account.

This patch helps to identify the problem, it work as expected, when completing a sign up, it redirects to verfication page.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants