-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename "phone" courier channel to "sms" #3680
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3680 +/- ##
==========================================
- Coverage 78.34% 78.33% -0.01%
==========================================
Files 346 346
Lines 23548 23551 +3
==========================================
Hits 18448 18448
+ Misses 3711 3710 -1
- Partials 1389 1393 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor things. For recovery we'll do the same, but we don't yet support SMS recovery, right?
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments