Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename "phone" courier channel to "sms" #3680

Merged
merged 9 commits into from
Jan 5, 2024

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Jan 3, 2024
aeneasr
aeneasr previously approved these changes Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (699e5d5) 78.34% compared to head (7e22049) 78.33%.

Files Patch % Lines
identity/extension_verification.go 80.64% 3 Missing and 3 partials ⚠️
courier/http_channel.go 20.00% 4 Missing ⚠️
request/builder.go 0.00% 4 Missing ⚠️
selfservice/strategy/code/code_sender.go 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3680      +/-   ##
==========================================
- Coverage   78.34%   78.33%   -0.01%     
==========================================
  Files         346      346              
  Lines       23548    23551       +3     
==========================================
  Hits        18448    18448              
+ Misses       3711     3710       -1     
- Partials     1389     1393       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hperl
hperl previously approved these changes Jan 3, 2024
courier/sms.go Outdated Show resolved Hide resolved
@jonas-jonas jonas-jonas dismissed stale reviews from hperl and aeneasr via 9808796 January 5, 2024 10:01
@jonas-jonas jonas-jonas changed the title fix: add missing type in courier channel config schema fix: rename "phone" courier channel to "sms" Jan 5, 2024
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things. For recovery we'll do the same, but we don't yet support SMS recovery, right?

identity/extension_verification.go Show resolved Hide resolved
identity/identity_verification.go Outdated Show resolved Hide resolved
identity/extension_verification.go Outdated Show resolved Hide resolved
identity/identity_verification.go Show resolved Hide resolved
@zepatrik zepatrik merged commit eb8d1b9 into master Jan 5, 2024
28 of 29 checks passed
@zepatrik zepatrik deleted the jonas-jonas/missingTypeInSchema branch January 5, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants