Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing tracing in manager_cookie.go #3615

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please :)

@hperl hperl enabled auto-merge (squash) November 10, 2023 13:00
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #3615 (ae93cf3) into master (912dccd) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 89.47%.

❗ Current head ae93cf3 differs from pull request most recent head e98583d. Consider uploading reports for the commit e98583d to get more accurate results

@@           Coverage Diff           @@
##           master    #3615   +/-   ##
=======================================
  Coverage   78.29%   78.30%           
=======================================
  Files         342      342           
  Lines       23395    23402    +7     
=======================================
+ Hits        18317    18324    +7     
  Misses       3699     3699           
  Partials     1379     1379           
Files Coverage Δ
continuity/manager_cookie.go 54.16% <89.47%> (+4.93%) ⬆️

@hperl hperl merged commit f7c6767 into master Nov 10, 2023
23 checks passed
@hperl hperl deleted the jonas-jonas/fixTracingContinuityContainer branch November 10, 2023 14:04
moose115 pushed a commit to moose115/kratos that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants