Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refresh a supabase example #60

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

WIP: Refresh a supabase example #60

wants to merge 16 commits into from

Conversation

drev74
Copy link

@drev74 drev74 commented Nov 24, 2022

Related Issue or Design Document

I'm trying to reproduce kratos-keto-oathkeeper-supabase without bumping ory deps. I've simplified the compose by removing redundant postgres versions.

However, I can't make it work having an issue with keto-perms:

time=2022-11-24T19:42:39Z level=debug msg=Ignoring migration file 20150100000001000000_networks.sqlite3.down.sql because dialect is not supported: unsupported
 dialect sqlite3 audience=application service_name=ORY Keto service_version=v0.7.0-alpha.1                                                                    
time=2022-11-24T19:42:39Z level=debug msg=Ignoring migration file 20150100000001000000_networks.sqlite3.up.sql because dialect is not supported: unsupported d
ialect sqlite3 audience=application service_name=ORY Keto service_version=v0.7.0-alpha.1                                                             
Migrations were not applied yet, please apply them first.% 

Original impl doesn't work for me as well.

Could anyone pls help me to reproduce the example?

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ drev74
❌ tetra12
You have signed the CLA already but the status is still pending? Let us recheck it.

@vinckr
Copy link
Member

vinckr commented Nov 28, 2022

Hey, thanks for looking into it!
The example probably needs a good updating.. I will see to look into this PR and see if I can reproduce this week :)

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty good!

Should I already review?
Could you please share the steps that you use to run the example now?

I would also update our existing tutorial after merging and we should improve the README - the current one is also lacking concise steps to run locally.

Thanks for your contribution!

@drev74
Copy link
Author

drev74 commented Dec 1, 2022

Guten tag @vinckr

WIP in PR stands for Work-in-Progress 👀 . I've not yet finished. Now updating a client. I'll remove the WIP and ping you when I'm ready

Vielen dank 😎

@drev74
Copy link
Author

drev74 commented Dec 1, 2022

@vinckr has smth changed recently? I can't instantiate an Ory Agent with:

const ory = new V0alpha2Api(...)
error - V0alpha2Api is not found

Switched to ory/client v1.0.1

@vinckr
Copy link
Member

vinckr commented Dec 1, 2022

@drev74 yes the syntax has changed a bit,

const ory = {
- v0alpha2: V0alpha2Api
+ identity: new IdentityApi(config)
+ frontend: new FrontendApi(config),
+ oauth2: new OAuth2Api(config),
}

see the upgrade guide:
https://www.ory.sh/docs/guides/upgrade/sdk-v1

its pretty new, so any feedback appreciated 🙏 we are also working on more docs

feat (make): add shorts api test
@drev74
Copy link
Author

drev74 commented Dec 1, 2022

@vinckr Could you pls help me a bit 👀 . I'm trying to implement a login-logout for a Vite Client here.

I added an allowed return URL for kratos here
However, when I press Logout I'm getting this:

{
  "code": 403,
  "reason": "Unable to log out because the logout token in the URL query does not match the session cookie.",
  "status": "Forbidden",
  "message": "The requested action was forbidden"
}

Any ideas 🤔

PS: I see a major bump to ORY v1. I'll try to bump all my stuff and try again 🙄
PPS: Fixed after bump 😎

fix (kratos): add localhost to valid return URLs
@vinckr vinckr marked this pull request as draft June 5, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants