Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Feat/remove schema types #124

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] Feat/remove schema types #124

wants to merge 2 commits into from

Conversation

jpower432
Copy link
Contributor

@jpower432 jpower432 commented Dec 16, 2022 •
edited
Loading

Description

This PR removes the types in the Schema Configuration. With the addition of #125, using existing JSON schema with complex data types will be supported.

Fixes #74

Related to #125

Type of change

UX CHANGE!

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Requires updates to the Getting Started Guide

@jpower432 jpower432 marked this pull request as draft December 16, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFE] Expose optional attribute toggle in schema config
1 participant
@jpower432