Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting #55 to ognl-3-1-x branch. #56

Merged
merged 2 commits into from
Oct 4, 2018

Conversation

harawata
Copy link
Contributor

@harawata harawata commented Oct 3, 2018

getDeclaredMethods() should search super-interfaces recursively.

@harawata
Copy link
Contributor Author

harawata commented Oct 3, 2018

I noticed that 3.1.x still uses Introspector#getBeanInfo() in getReadMethod() (i.e. #33 was not backported).
So, the following tests will fail.

// In Java8Test
Method method = OgnlRuntime.getReadMethod(ClassWithDefaults.class, "defaultMethod");
assertNotNull(method);
Method method = OgnlRuntime.getReadMethod(SubClassWithDefaults.class, "defaultMethod");
assertNotNull(method);

I am going to fix this in the next PR.

@lukaszlenart
Copy link
Collaborator

I assume it's ready, right?

@harawata
Copy link
Contributor Author

harawata commented Oct 4, 2018

I believe it is, yes. :)

@lukaszlenart
Copy link
Collaborator

LGTM 👍

@lukaszlenart lukaszlenart merged commit 8510935 into orphan-oss:ognl-3-1-x Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants