Optimization: avoid using java.lang.String#replaceAll() in most cases #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
lukaszlenart
added a commit
that referenced
this pull request
May 17, 2015
Optimization: avoid using java.lang.String#replaceAll() in most cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several parts of OGNL call the
java.lang.String#replaceAll(...)method, which is extremely inefficient because it first compiles ajava.util.regex.Pattern, then aMatcher, and finally asks thisMatcherto perform the replace operation.In order to avoid most of the calls to this method without disrupting the code base too much, I've added before each call a condition based on a call to
java.lang.String#indexOf(...), which is hugely more efficient because it acts directly on theString's innerchar[]. And only if thisindexOf(...)determines there is a possibility that thereplaceAll(...)operation would actually do something,replaceAll(...)will be called.