WorflowEntityValidator allow object #952
Conversation
If entity contains some object rather than entity and it goes to validator it throws not manageable error. We have lots of DataTypes in our code. This is just an unnecessary restriction.
|
@vytsci Workflow engine in OroPlatform is built for transitioning entities through different steps of a workflow, and the entity restrictions are also for entities - https://github.com/oroinc/platform/blob/master/src/Oro/Bundle/WorkflowBundle/Resources/doc/reference/workflow/configuration-reference.md#entity-restrictions-configuration Why would there ever be a non-entity object? |
|
Issue is that we have status as an object, but it can be managed as a string, and ORO thinks that if you have property and it is an object it must be an entity and it should not be like that. I understand that relations must be entities, but for example DateTime is also an object and if you add that to this equation it will also throw non configurable entity error. |
| $fieldValue = $this->doctrineHelper->getSingleEntityIdentifier($fieldValue); | ||
| $fieldValue = $this->doctrineHelper->isManageableEntity($fieldValue) ? | ||
| $this->doctrineHelper->getSingleEntityIdentifier($fieldValue) : | ||
| (string)$fieldValue; |
There was a problem hiding this comment.
What if the related object doesn't implement the __toString() method?
If entity contains some object rather than entity and it goes to validator it throws not manageable error. We have lots of DataTypes in our code. This is just an unnecessary restriction.