Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liftoff app master #2

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
385f77f
Explicitly sends text field contents on save (#436)
mykdavies Jul 19, 2023
0b6137f
De-duplicate contents of infinite scroll (#441)
shocklateboy92 Jul 23, 2023
8fa4645
Make list refresh work again (#443)
shocklateboy92 Jul 23, 2023
13ee1c2
Disable rounded corners/shadow and darken background of light theme (…
shocklateboy92 Jul 23, 2023
1d7cc6d
Show link thumbnails in full height cards (#444)
shocklateboy92 Jul 23, 2023
defaac1
Make VideoPlayer play nicely (#449)
mykdavies Jul 23, 2023
0364fd5
AppStore link, Weblate text (#446)
mykdavies Jul 23, 2023
abb6188
updated changelog
zachatrocity Jul 29, 2023
5ceaafb
Release v0.10.10
zachatrocity Jul 29, 2023
8d7a447
Users can edit list of instances to block (#372)
mykdavies Aug 1, 2023
787d7f9
MediaView restores system style (#475)
mykdavies Aug 7, 2023
3055896
Splitscreen support (#463)
mykdavies Aug 21, 2023
fee667f
Merge branch 'master' of https://github.com/liftoff-app/liftoff into …
orl0pl Nov 23, 2023
99097ff
Update main.yml
orl0pl Nov 23, 2023
0e898d4
fixed bugs
orl0pl Nov 23, 2023
1d0d488
Merge branch 'liftoff-app-master' of https://github.com/orl0pl/lemmon…
orl0pl Nov 23, 2023
33ed1cc
fixed theme problem
orl0pl Nov 23, 2023
67c5a1a
updated depedencies
orl0pl Nov 24, 2023
b0d3558
maybe this will fix
orl0pl Nov 24, 2023
98e84a5
fixed?
orl0pl Nov 24, 2023
c1f71fe
disabled keystore
orl0pl Nov 24, 2023
3176399
updated github actions
orl0pl Dec 29, 2023
c255a16
changed main.yml
orl0pl Dec 29, 2023
63e9dd1
updated main.yml (again)
orl0pl Dec 29, 2023
fd8618a
updated main.yml (again)
orl0pl Dec 29, 2023
1d9caff
updated main.yml
orl0pl Dec 29, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 5 additions & 25 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:

- uses: subosito/flutter-action@v1
with:
channel: "stable"
flutter-version: '3.16.0'

- name: Disable telemetry
run: flutter --disable-telemetry
run: flutter --disable-analytics

- name: Get dependencies
run: flutter pub get
Expand Down Expand Up @@ -55,35 +55,15 @@ jobs:

- uses: subosito/flutter-action@v1
with:
channel: "stable"

- name: Generate debug keystore (Pull Request)
if: github.event_name == 'pull_request'
run: keytool -genkey -v -keystore /home/runner/work/liftoff/liftoff/android/app/key.jks -alias androiddebugkey -storepass android -keypass android -keyalg RSA -keysize 2048 -validity 10000 -dname "CN=Android Debug,O=Android,C=US"
flutter-version: '3.16.0'

- name: Android build (Pull Request)
if: github.event_name == 'pull_request'
env:
ANDROID_KEY_ALIAS: androiddebugkey
ANDROID_KEY_PASSWORD: android
ANDROID_STORE_PATH: key.jks
ANDROID_STORE_PASSWORD: android
run: flutter build apk --split-per-abi --release --target lib/main_prod.dart --flavor preview

- name: Inject keystore
working-directory: android/app
if: github.event_name != 'pull_request'
run: |
echo "${{ secrets.SIGNING_KEY }}" | base64 -d | tee key.jks >/dev/null
run: flutter build apk --release --target lib/main_prod.dart --flavor preview

- name: Android build (Master Branch)
if: github.event_name != 'pull_request'
env:
ANDROID_KEY_ALIAS: ${{ secrets.ALIAS }}
ANDROID_KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
ANDROID_STORE_PATH: key.jks
ANDROID_STORE_PASSWORD: ${{ secrets.KEY_STORE_PASSWORD }}
run: flutter build apk --split-per-abi --release --target lib/main_prod.dart --flavor preview
run: flutter build apk --release --target lib/main_prod.dart

- uses: actions/upload-artifact@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
/build/
lib/l10n/gen
# We regenerate this every time due to logic in Podfile `post_install` section.
/ios/Podfile.lock
ios/Podfile.lock

# Web related
lib/generated_plugin_registrant.dart
Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## v0.10.10 - 2023-07-29
- Fixed issues with video player
- Show thumbnails in full height cards
- Fixed list view refresh
- Updated defaults for themes
- Remove duplicates from infinite scroll

## v0.10.9 - 2023-07-14
- More design tweaks (zachatrocity)
- Improvements to swipe actions (shocklateboy92)
Expand Down
6 changes: 4 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@ Everything is formatted with `dart format` (no flags) and linted with `flutter a

## Translations

### Weblate
We intend to eventually use Weblate to allow you to contribute translation strings to Liftoff, but in the meantime you can look at the files in /assets/i10n -- intl_en.arb is our master file, which contains all the strings that should be translated, and the others are translation files contributed by our users. If you want to add or update a translation file before we get Weblate up and running, you can create an issue in GitHub with the translation file attached and we can add it into the build.

Lemmy devs are kindly hosting liftoff translation strings on their [Weblate instance](https://weblate.yerbamate.ml/projects/liftoff/liftoff/). Feel free to contribute strings there, we regularly sync string changes with Weblate.
<!-- ### Weblate

Lemmy devs are kindly hosting liftoff translation strings on their [Weblate instance](https://weblate.yerbamate.ml/projects/liftoff/liftoff/). Feel free to contribute strings there, we regularly sync string changes with Weblate.
-->
We use flutter's native file format for translations: ARB, which itself uses the ICU message syntax. In most cases you will be able to deduce the syntax based on the source string. Here are 3 important examples:

1. Placeholders
Expand Down
46 changes: 46 additions & 0 deletions assets/download-on-app-store.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
14 changes: 12 additions & 2 deletions assets/l10n/intl_en.arb
Original file line number Diff line number Diff line change
Expand Up @@ -705,5 +705,15 @@
"comment_tag_you": "YOU",
"@comment_tag_you": {},
"code_of_conduct_clickthrough": "By accessing the Lemmy network using Liftoff! you agree to adhere to our Code of Conduct",
"@code_of_conduct_clickthrough": {}
}
"@code_of_conduct_clickthrough": {},
"instance_filter": "Instance filter",
"@instance_filter": {},
"instance_filter_explanation": "A list of terms in names of instances you wish to block from all your post feeds. A good start is: nsfw porn yiff",
"@instance_filter_explanation": {},
"instance_filter_add": "Add term",
"@instance_filter_add": {},
"instance_filter_none": "No filters chosen",
"@instance_filter_none": {},
"sensitive_content": "Sensitive Content",
"@sensitive_content": {}
}
5 changes: 5 additions & 0 deletions fastlane/metadata/android/en-US/changelogs/32.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
- Show thumbnails in full height cards
- Fixed list view refresh
- Updated defaults for themes
- Remove duplicates from infinite scroll

5 changes: 5 additions & 0 deletions ios/Runner.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,7 @@
baseConfigurationReference = E1A6772F7FB9970AB1AB2682 /* Pods-Runner.debug-prod.xcconfig */;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_INCLUDE_ALL_APPICON_ASSETS = NO;
BUNDLE_NAME = "Liftoff!";
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_ENTITLEMENTS = Runner/Runner.entitlements;
Expand Down Expand Up @@ -465,6 +466,7 @@
baseConfigurationReference = 1DDB765AC59CE6BE74A0D52A /* Pods-Runner.release-prod.xcconfig */;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_INCLUDE_ALL_APPICON_ASSETS = NO;
BUNDLE_NAME = "Liftoff!";
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_ENTITLEMENTS = Runner/Runner.entitlements;
Expand Down Expand Up @@ -554,6 +556,7 @@
baseConfigurationReference = DC3DFF228D52D7ED36CDD540 /* Pods-Runner.profile-dev.xcconfig */;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_INCLUDE_ALL_APPICON_ASSETS = NO;
BUNDLE_NAME = "Liftoff! DEV";
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_ENTITLEMENTS = Runner/Runner.entitlements;
Expand Down Expand Up @@ -702,6 +705,7 @@
baseConfigurationReference = 6AE5AC98872EE326B6FB9182 /* Pods-Runner.debug-dev.xcconfig */;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_INCLUDE_ALL_APPICON_ASSETS = NO;
BUNDLE_NAME = "Liftoff! DEV";
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_ENTITLEMENTS = Runner/Runner.entitlements;
Expand Down Expand Up @@ -740,6 +744,7 @@
baseConfigurationReference = 7E657A51BD7C018DCF5B54AD /* Pods-Runner.release-dev.xcconfig */;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
ASSETCATALOG_COMPILER_INCLUDE_ALL_APPICON_ASSETS = NO;
BUNDLE_NAME = "Liftoff! DEV";
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_ENTITLEMENTS = Runner/Runner.entitlements;
Expand Down
3 changes: 3 additions & 0 deletions ios/Runner/Assets.xcassets/LaunchImage.imageset/Contents.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"images" : [
{
"filename" : "app_icon_monochrome.png",
"idiom" : "universal",
"scale" : "1x"
},
Expand All @@ -15,6 +16,7 @@
"scale" : "1x"
},
{
"filename" : "app_icon_monochrome 1.png",
"idiom" : "universal",
"scale" : "2x"
},
Expand All @@ -29,6 +31,7 @@
"scale" : "2x"
},
{
"filename" : "app_icon_monochrome 2.png",
"idiom" : "universal",
"scale" : "3x"
},
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion ios/Runner/Base.lproj/LaunchScreen.storyboard
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@
</scene>
</scenes>
<resources>
<image name="LaunchImage" width="666.66668701171875" height="1333.3333740234375"/>
<image name="LaunchImage" width="500" height="500"/>
</resources>
</document>
4 changes: 2 additions & 2 deletions ios/Runner/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@
<key>UIApplicationSupportsIndirectInputEvents</key>
<true/>
<key>UILaunchStoryboardName</key>
<string>LaunchScreen.storyboard</string>
<string>LaunchScreen</string>
<key>UIMainStoryboardFile</key>
<string>Main</string>
<key>UIRequiresFullScreen</key>
<true/>
<false/>
<key>UISupportedInterfaceOrientations</key>
<array>
<string>UIInterfaceOrientationPortrait</string>
Expand Down
2 changes: 1 addition & 1 deletion lib/hooks/stores.dart
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ V useStore<S extends Store, V>(V Function(S value) selector) {
useEffect(() {
return autorun((_) {
state.value = selector(store);
});
}).call;
}, []);

return state.value;
Expand Down
2 changes: 2 additions & 0 deletions lib/pages/communities_tab.dart
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// ignore_for_file: use_build_context_synchronously

import 'dart:async';

import 'package:collection/collection.dart';
Expand Down
Loading
Loading