Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed previously in #80. This should be a valid public api in persistent data-structures. It's already in im and in the stdlib.
It's valuable in a some cases as an identity check but also as a fast-path to avoid expensive set computations (intersection, union, etc.). In our application, we take great advantage of the latter.
Furthermore, persistent data structures in practice always(?) have efficient ptr_eq implementations, otherwise it would imply cloning isn't cheap or can't be done with a non-mut pointer. So it's likely to be future-proof even.