Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add loading/splash screen #55

Merged
merged 2 commits into from
Sep 29, 2024
Merged

feat(ui): add loading/splash screen #55

merged 2 commits into from
Sep 29, 2024

Conversation

orhun
Copy link
Owner

@orhun orhun commented Sep 28, 2024

Description of change

This PR adds the project logo in the loading screen. It's absolutely useless but looks cool - only steals 500ms of your time.

rec_20240929T004840

I still need to fix the issue where the splash screen is show while switching from shared libraries.

How has this been tested? (if applicable)

On a livestream.

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 3.41%. Comparing base (3ec5db4) to head (992750f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/tui/widgets/logo.rs 0.00% 20 Missing ⚠️
src/tui/ui.rs 0.00% 15 Missing ⚠️
src/tui/state.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #55      +/-   ##
========================================
- Coverage   3.47%   3.41%   -0.05%     
========================================
  Files         18      19       +1     
  Lines       2340    2376      +36     
========================================
  Hits          81      81              
- Misses      2259    2295      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun merged commit b1116e6 into main Sep 29, 2024
26 of 27 checks passed
@orhun orhun deleted the feat/add_splash branch September 29, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant